Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DataPlaneStore): implements SQL based storage for DataPlane flow requests #2159

Merged

Conversation

wolf4ood
Copy link
Contributor

@wolf4ood wolf4ood commented Nov 2, 2022

What this PR changes/adds

Adds a SQL implementation of DataPlaneStore

Why it does that

Currently one an in memory version is provided for the DataPlaneStore.

Linked Issue(s)

Closes #2090

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • assigned appropriate label? (exclude from changelog with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and Etiquette for pull requests for details)

@wolf4ood wolf4ood added the enhancement New feature or request label Nov 2, 2022
@github-actions github-actions bot added this to In progress in Connector Nov 2, 2022
@wolf4ood wolf4ood temporarily deployed to Azure-dev November 2, 2022 16:43 Inactive
@wolf4ood wolf4ood force-pushed the feature/2090_sql_dataplane_store branch from 6042972 to c97cdcb Compare November 2, 2022 16:45
@wolf4ood wolf4ood temporarily deployed to Azure-dev November 2, 2022 16:46 Inactive
@wolf4ood wolf4ood changed the title feature(DataPlaneStore): implements SQL based storage for DataPlane flow requests feat(DataPlaneStore): implements SQL based storage for DataPlane flow requests Nov 2, 2022
@wolf4ood wolf4ood self-assigned this Nov 2, 2022
@wolf4ood wolf4ood force-pushed the feature/2090_sql_dataplane_store branch 2 times, most recently from 1bfee9f to 6d1c9d7 Compare November 2, 2022 16:54
@wolf4ood wolf4ood temporarily deployed to Azure-dev November 2, 2022 16:55 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2022

Codecov Report

Base: 64.47% // Head: 64.20% // Decreases project coverage by -0.26% ⚠️

Coverage data is based on head (b54764b) compared to base (f4913e5).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2159      +/-   ##
==========================================
- Coverage   64.47%   64.20%   -0.27%     
==========================================
  Files         836      841       +5     
  Lines       17406    17479      +73     
  Branches     1102     1104       +2     
==========================================
  Hits        11223    11223              
- Misses       5725     5798      +73     
  Partials      458      458              
Impacted Files Coverage Δ
...nnector/dataplane/store/sql/SqlDataPlaneStore.java 0.00% <0.00%> (ø)
...ataplane/store/sql/SqlDataPlaneStoreExtension.java 0.00% <0.00%> (ø)
...e/store/sql/schema/BaseSqlDataPlaneStatements.java 0.00% <0.00%> (ø)
...ataplane/store/sql/schema/DataPlaneStatements.java 0.00% <0.00%> (ø)
...l/schema/postgres/PostgresDataPlaneStatements.java 0.00% <0.00%> (ø)
.../connector/dataplane/spi/store/DataPlaneStore.java 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wolf4ood wolf4ood marked this pull request as ready for review November 2, 2022 17:54
@wolf4ood wolf4ood temporarily deployed to Azure-dev November 3, 2022 09:24 Inactive
@wolf4ood wolf4ood force-pushed the feature/2090_sql_dataplane_store branch from ec012e2 to 99db732 Compare November 3, 2022 11:48
@wolf4ood wolf4ood temporarily deployed to Azure-dev November 3, 2022 11:48 Inactive
Connector automation moved this from In progress to Review in progress Nov 3, 2022
@wolf4ood wolf4ood force-pushed the feature/2090_sql_dataplane_store branch from 99db732 to 8bcc19e Compare November 3, 2022 15:57
@wolf4ood wolf4ood temporarily deployed to Azure-dev November 3, 2022 15:57 Inactive
@wolf4ood wolf4ood force-pushed the feature/2090_sql_dataplane_store branch from 8bcc19e to f004c4f Compare November 3, 2022 16:00
@wolf4ood wolf4ood temporarily deployed to Azure-dev November 3, 2022 16:06 Inactive
@wolf4ood wolf4ood force-pushed the feature/2090_sql_dataplane_store branch from 9580554 to 7346f39 Compare November 3, 2022 16:13
@wolf4ood wolf4ood temporarily deployed to Azure-dev November 3, 2022 16:20 Inactive
@wolf4ood wolf4ood force-pushed the feature/2090_sql_dataplane_store branch from 7346f39 to ff234f7 Compare November 7, 2022 10:32
@wolf4ood wolf4ood temporarily deployed to Azure-dev November 7, 2022 10:32 Inactive
@wolf4ood wolf4ood force-pushed the feature/2090_sql_dataplane_store branch from ff234f7 to 5b4be1e Compare November 8, 2022 08:43
@wolf4ood wolf4ood temporarily deployed to Azure-dev November 8, 2022 08:44 Inactive
@wolf4ood wolf4ood force-pushed the feature/2090_sql_dataplane_store branch from 5b4be1e to fe18641 Compare November 8, 2022 13:47
@wolf4ood wolf4ood temporarily deployed to Azure-dev November 8, 2022 13:48 Inactive
@wolf4ood wolf4ood force-pushed the feature/2090_sql_dataplane_store branch from fe18641 to 8b61f67 Compare November 8, 2022 15:21
@wolf4ood wolf4ood temporarily deployed to Azure-dev November 8, 2022 15:22 Inactive
@wolf4ood wolf4ood force-pushed the feature/2090_sql_dataplane_store branch from 8b61f67 to 70b83fc Compare November 9, 2022 08:27
@wolf4ood wolf4ood temporarily deployed to Azure-dev November 9, 2022 08:27 Inactive
@wolf4ood wolf4ood force-pushed the feature/2090_sql_dataplane_store branch from 70b83fc to b54764b Compare November 9, 2022 08:44
@wolf4ood wolf4ood temporarily deployed to Azure-dev November 9, 2022 08:44 Inactive
@wolf4ood wolf4ood force-pushed the feature/2090_sql_dataplane_store branch from b54764b to aeecb68 Compare November 10, 2022 14:06
@wolf4ood wolf4ood temporarily deployed to Azure-dev November 10, 2022 14:07 Inactive
@paullatzelsperger paullatzelsperger merged commit f163b32 into eclipse-edc:main Nov 14, 2022
Connector automation moved this from Review in progress to Done Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Connector
  
Done
Development

Successfully merging this pull request may close these issues.

Persistent DataPlaneStore - SQL extension
4 participants