feat(DataPlaneStore): adds Cosmos implementation for DataPlaneStore #2203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 64.50% // Head: 64.29% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2203 +/- ##
==========================================
- Coverage 64.50% 64.29% -0.21%
==========================================
Files 843 847 +4
Lines 17545 17602 +57
Branches 1087 1089 +2
==========================================
Hits 11317 11317
- Misses 5780 5837 +57
Partials 448 448
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
wolf4ood
force-pushed
the
feature/2091_dataplane_store_cosmos
branch
from
3cb1af4
to
c6384b8
Compare
wolf4ood
force-pushed
the
feature/2091_dataplane_store_cosmos
branch
from
c6384b8
to
b5b36d0
Compare
|
|
||
| public class CosmosDataPlaneStoreConfig extends AbstractCosmosConfig { | ||
|
|
||
| @Setting |
There was a problem hiding this comment.
nit: should use the attributes to add more documentation
| var cosmosDbApi = new CosmosDbApiImpl(configuration, client); | ||
| var store = new CosmosDataPlaneStore(cosmosDbApi, typeManager.getMapper(), retryPolicy, configuration.getPartitionKey(), clock); | ||
|
|
||
| context.registerService(DataPlaneStore.class, store); |
There was a problem hiding this comment.
could use a @Provider method for this?
wolf4ood
force-pushed
the
feature/2091_dataplane_store_cosmos
branch
from
b5b36d0
to
6005d61
Compare
bscholtes1A
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Adds a Cosmos implementation of
DataPlaneStoreLinked Issue(s)
Closes #2091
Checklist
no-changelog)