-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(doc): update the verification and generation of OpenAPI spec files #2209
feat(doc): update the verification and generation of OpenAPI spec files #2209
Conversation
f5b6ace
to
6dcf1dd
Compare
6dcf1dd
to
b034c96
Compare
Codecov ReportBase: 64.81% // Head: 64.66% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2209 +/- ##
==========================================
- Coverage 64.81% 64.66% -0.15%
==========================================
Files 828 830 +2
Lines 17452 17460 +8
Branches 1091 1091
==========================================
- Hits 11312 11291 -21
- Misses 5690 5719 +29
Partials 450 450
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
76dfd75
to
1cfef37
Compare
1cfef37
to
4d7bba8
Compare
4d7bba8
to
f718853
Compare
f718853
to
324909f
Compare
324909f
to
1592ffb
Compare
71ac456
to
06cd9b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we wait to have the swagger hub uploaded and reachable from the docs
site before removing the current swaggerui? Just to avoid 404s in the meantime.
on: | ||
push: | ||
pull_request: | ||
branches: [ main ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this branches: [ main ]
need to be moved under the push
block?
Otherwise this workflow will be executed for every push and this pull_request
block would be useless.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on the upstream repo, the only pushes should be merged PRs to main
, so in reality it'll be the same thing. I copied the declaration from the verify.yaml
.
Due to the fact that we don't have one single yaml file anymore, but one per api we cannot (easily) generate embedded swagger UI anymore, and if I leave the old one in, it'll be incorrect and won't reflect the code. |
@paullatzelsperger I don't say that we need to keep the process of ui generation, just to leave the static files there for some times until we have a replacement for them |
If we do that, it should be clear to anyone looking at it, that they're looking at a potentially outdated version of the API. But we can do it. |
7860511
to
17e8bdf
Compare
This pull request is stale because it has been open for 7 days with no activity. |
17e8bdf
to
3ec284d
Compare
5ed4748
to
6d60eaf
Compare
6d60eaf
to
38fd935
Compare
38fd935
to
5ca2bdd
Compare
…es (#2209) * feat: apply apiGroup configs * delete embedded swagger UI * bring back old and outdated Swagger UI * updated api specs * create-update logic for API doc
What this PR changes/adds
apiGroup
property to all API-producing modules-PapiTitle="some title" -PapiDescription="some description"
)apidoc.yaml
that:Why it does that
Improve API separation and documentation
Further notes
publishing to SwaggerHub is currently a placeholder, because EDC doesn't have an account there yet.SWAGGERHUB_TOKEN
) is only present on the upstream repodocs/swaggerui
) was deletedLinked Issue(s)
Closes #2206
Closes #2163
Checklist
no-changelog
)