Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GitHub): add support for new GitHub project #2358

Merged

Conversation

juliapampus
Copy link
Contributor

What this PR changes/adds

Unify old actions for assigning PRs and issues to a new one. Replaced action type.

Why it does that

The classic project was migrated to a new one: https://github.com/orgs/eclipse-edc/projects. With this, a new project number was created. In addition, the old action does not support the new GitHub projects API.

Further notes

Could happen that we again face issues regarding PR assignments. As we are creating PRs from forks, the event type pull_request_target instead of pull_request had to be used with the old action. According to the readme and issues, this may not be supported by the new action yet. We have to try it out.

Linked Issue(s)

Relates #2356

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • assigned appropriate label? (exclude from changelog with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and Etiquette for pull requests for details)

@juliapampus juliapampus added the build Anything related to the CI/CD Pipeline on Github Actions label Dec 16, 2022
@juliapampus juliapampus temporarily deployed to Azure-dev December 16, 2022 13:49 — with GitHub Actions Inactive
@codecov-commenter
Copy link

Codecov Report

Base: 64.37% // Head: 64.37% // No change to project coverage 👍

Coverage data is based on head (2c942b2) compared to base (857cb5d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2358   +/-   ##
=======================================
  Coverage   64.37%   64.37%           
=======================================
  Files         832      832           
  Lines       17303    17303           
  Branches     1043     1043           
=======================================
  Hits        11139    11139           
  Misses       5728     5728           
  Partials      436      436           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@juliapampus
Copy link
Contributor Author

juliapampus commented Dec 16, 2022

For the record:

Using pull_request as event trigger is causing a known issue:
image

Using pull_request_target seems to work, but, as the documentation of the action state, we need a personal access token (PAT) that allows to interact with GitHub projects on an organizational level. This seems not to be covered by secrets.GITHUB_TOKEN of this repository.
image

@juliapampus juliapampus temporarily deployed to Azure-dev December 16, 2022 14:21 — with GitHub Actions Inactive
@juliapampus juliapampus temporarily deployed to Azure-dev December 16, 2022 15:16 — with GitHub Actions Inactive
@juliapampus
Copy link
Contributor Author

We would need to request the EF to create a secret named ORGANIZATION_PROJECT (suggestion, as in this PR) to this repo (and all others that should have this action), with access to repo and organization-projects (or similar) scope.

@ronjaquensel ronjaquensel merged commit 3129a1a into eclipse-edc:main Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Anything related to the CI/CD Pipeline on Github Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants