Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: separate multiple state transitions #2970

Merged

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented May 12, 2023

What this PR changes/adds

Avoid the Contract service protocol to do a multiple state transition (REQUESTED and AGREEING).
service -> transition to REQUESTED
manager -> transition to AGREEING

Why it does that

Briefly state why the change was necessary.

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes #2962

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • assigned appropriate label? (exclude from changelog with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and Etiquette for pull requests for details)

@ndr-brt ndr-brt temporarily deployed to Azure-dev May 12, 2023 06:31 — with GitHub Actions Inactive
@ndr-brt ndr-brt added dataspace-protocol related to the dataspace protocol enhancement New feature or request labels May 12, 2023
@ndr-brt ndr-brt merged commit 4b56261 into eclipse-edc:main May 12, 2023
@ndr-brt ndr-brt deleted the 2962-improve-negotiation-state-machine branch May 12, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dataspace-protocol related to the dataspace protocol enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ContractServiceProtocol should not put negotiation in AGREEING directly
3 participants