Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid pointless response handling in TransferRequestDelegate #2973

Merged

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented May 12, 2023

What this PR changes/adds

that transformation would break anyway because we haven't a transformer from json to TransferProcess

Why it does that

Briefly state why the change was necessary.

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes #2958

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • assigned appropriate label? (exclude from changelog with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and Etiquette for pull requests for details)

@ndr-brt ndr-brt added bug Something isn't working dataspace-protocol related to the dataspace protocol labels May 12, 2023
@ndr-brt ndr-brt temporarily deployed to Azure-dev May 12, 2023 06:55 — with GitHub Actions Inactive
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.02 ⚠️

Comparison is base (854743c) 66.21% compared to head (06d2213) 66.20%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2973      +/-   ##
==========================================
- Coverage   66.21%   66.20%   -0.02%     
==========================================
  Files        1040     1040              
  Lines       21310    21299      -11     
  Branches     1261     1261              
==========================================
- Hits        14111    14101      -10     
  Misses       6673     6673              
+ Partials      526      525       -1     
Impacted Files Coverage Δ
...patcher/DspTransferProcessDispatcherExtension.java 0.00% <0.00%> (ø)
...s/dispatcher/delegate/TransferRequestDelegate.java 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ndr-brt ndr-brt merged commit 91a0620 into eclipse-edc:main May 12, 2023
30 checks passed
@ndr-brt ndr-brt deleted the 2958-transfer-request-delegate branch May 12, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dataspace-protocol related to the dataspace protocol
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TransferRequestDelegate should not parse the response
4 participants