fix: specialize ContractId only for offers, not agreements
#3407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
force-pushed
the
3403-avoid-using-contract-id-for-agreements
branch
from
b3ec2a2
to
c901bd7
Compare
jimmarino
approved these changes
Sep 1, 2023
ndr-brt
force-pushed
the
3403-avoid-using-contract-id-for-agreements
branch
from
c901bd7
to
c9281b0
Compare
wolf4ood
approved these changes
Sep 1, 2023
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #3407 +/- ##
==========================================
- Coverage 72.22% 72.07% -0.15%
==========================================
Files 830 831 +1
Lines 16815 16828 +13
Branches 955 954 -1
==========================================
- Hits 12144 12129 -15
- Misses 4259 4288 +29
+ Partials 412 411 -1
☔ View full report in Codecov by Sentry. |
ndkrimbacher
pushed a commit
to nexyo-io/DataSpaceConnector
that referenced
this pull request
Oct 4, 2023
…-edc#3407) fix: specialize ContractId only for offers, not agreements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Renamed
ContractIdtoContractOfferIdand used it only for building/parsing contract offer ids, avoiding the use onContractAgreementWhy it does that
Interoperability, furthermore contract agreement id does not need to contain information about the contract definition and asset id (the agreement itself already contains asset id and the whole policy)
Further notes
Linked Issue(s)
Closes #3403
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.