feat: add state machine to DataPlaneManager
#3420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
requested review from
bscholtes1A,
jimmarino and
paullatzelsperger
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...in/java/org/eclipse/edc/connector/dataplane/framework/DataPlaneDefaultServicesExtension.java
Fixed
Show fixed
Hide fixed
Codecov ReportPatch coverage:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3420 +/- ##
==========================================
- Coverage 72.21% 71.96% -0.25%
==========================================
Files 835 837 +2
Lines 16838 17012 +174
Branches 953 948 -5
==========================================
+ Hits 12159 12243 +84
- Misses 4271 4364 +93
+ Partials 408 405 -3
☔ View full report in Codecov by Sentry. |
ndr-brt
force-pushed
the
3401-dataplane-state-machine
branch
5 times, most recently
from
8891f15
to
50f45f5
Compare
ndr-brt
force-pushed
the
3401-dataplane-state-machine
branch
from
50f45f5
to
82bca8a
Compare
paullatzelsperger
approved these changes
Sep 13, 2023
ndr-brt
force-pushed
the
3401-dataplane-state-machine
branch
from
4308c5a
to
289f4ec
Compare
ndr-brt
force-pushed
the
3401-dataplane-state-machine
branch
from
289f4ec
to
1334bc8
Compare
ndkrimbacher
pushed a commit
to nexyo-io/DataSpaceConnector
that referenced
this pull request
Oct 4, 2023
* feat: add state machine to DataPlaneManager * Trigger build * create databases before tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Make
DataPlaneManagerwork withStateMachineManager.This PR is quite big, but it's mostly adaptation to an already used pattern (like in
TransferProcessManager)Why it does that
Better state handling for data-plane
Further notes
data-plane-frameworkmodule as it was only used bydata-plane-coreLinked Issue(s)
Closes #3401
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.