New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add priority on DataFlowController
registration
#3428
Merged
ndr-brt
merged 1 commit into
eclipse-edc:main
from
Think-iT-Labs:3414-dataflowmanager-improve
Sep 11, 2023
Merged
feat: add priority on DataFlowController
registration
#3428
ndr-brt
merged 1 commit into
eclipse-edc:main
from
Think-iT-Labs:3414-dataflowmanager-improve
Sep 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
force-pushed
the
3414-dataflowmanager-improve
branch
from
September 8, 2023 15:11
94c907c
to
1a269ec
Compare
jimmarino
approved these changes
Sep 8, 2023
...transfer-core/src/main/java/org/eclipse/edc/connector/transfer/flow/DataFlowManagerImpl.java
Outdated
Show resolved
Hide resolved
wolf4ood
approved these changes
Sep 8, 2023
ndr-brt
force-pushed
the
3414-dataflowmanager-improve
branch
from
September 11, 2023 06:40
1a269ec
to
cc65bfb
Compare
Codecov ReportPatch coverage:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3428 +/- ##
=======================================
Coverage 72.09% 72.09%
=======================================
Files 830 834 +4
Lines 16818 16847 +29
Branches 954 953 -1
=======================================
+ Hits 12125 12146 +21
- Misses 4282 4289 +7
- Partials 411 412 +1
☔ View full report in Codecov by Sentry. |
ndkrimbacher
pushed a commit
to nexyo-io/DataSpaceConnector
that referenced
this pull request
Oct 4, 2023
…3428) feat: improve DataFlowController selection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Add priority on
DataFlowController
registrationWhy it does that
to permit having multiple
DataFlowController
s that could be chosen for a particular transfer, and having other used as fallback.This is useful when there's, for example, the
ProviderPushDataFlowController
that pretty much can transfer anything but there's a specificDataFlowController
for a particularsource
-todestination
transfer that will be chosen first if the priority set is bigger.Further notes
DataFlowManager
andDataFlowController
, now they accept the wholeTransferProcess
object.Linked Issue(s)
Closes #3414
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.