refactor: get rid of NoopTransferProcessClient
#3440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
added
refactoring
ndr-brt
requested review from
bscholtes1A,
jimmarino and
paullatzelsperger
as code owners
ndr-brt
force-pushed
the
3400-get-rid-noop-tp-client
branch
from
b7dcdf9
to
16509c7
Compare
jimmarino
approved these changes
Sep 12, 2023
ndr-brt
force-pushed
the
3400-get-rid-noop-tp-client
branch
from
16509c7
to
5e93add
Compare
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3440 +/- ##
==========================================
- Coverage 72.08% 72.07% -0.02%
==========================================
Files 834 834
Lines 16827 16826 -1
Branches 953 953
==========================================
- Hits 12130 12127 -3
- Misses 4287 4290 +3
+ Partials 410 409 -1
☔ View full report in Codecov by Sentry. |
ndkrimbacher
pushed a commit
to nexyo-io/DataSpaceConnector
that referenced
this pull request
Oct 4, 2023
* refactor: get rid of NoopTransferProcessClient * simplify test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Get rid of
NoopTransferProcessClientWhy it does that
enforce the need for a transfer process client implementation on data-plane (the http one is already provided by
control-plane-api-client)Further notes
cleaned up the
JettyServiceTest, avoiding the jersey dependency.Linked Issue(s)
Closes #3400
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.