Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: speed up e2e transfer tests #3443

Merged
merged 1 commit into from Sep 13, 2023

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Sep 12, 2023

What this PR changes/adds

Speed up E2E transfer test, by implementing a EdcClassRuntimesExtension that takes care of starting the runtimes once per every test classes.

Why it does that

CI

Further notes

  • had to add a check to force retry on the TransferProcessHttpClient because it's too quick in completing the transfer and the data-plane is not able to notify the completion because the entity is still leased. This implementation is useful also on production because it prevents eventual control-plane downs.

Linked Issue(s)

Closes #3442

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added the build Anything related to the CI/CD Pipeline on Github Actions label Sep 12, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 22.22% and project coverage change: +0.12% 🎉

Comparison is base (656e10e) 72.08% compared to head (915ea69) 72.21%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3443      +/-   ##
==========================================
+ Coverage   72.08%   72.21%   +0.12%     
==========================================
  Files         834      835       +1     
  Lines       16827    16839      +12     
  Branches      953      953              
==========================================
+ Hits        12130    12160      +30     
+ Misses       4287     4270      -17     
+ Partials      410      409       -1     
Files Changed Coverage Δ
...dc/junit/extensions/EdcClassRuntimesExtension.java 0.00% <0.00%> (ø)
...ent/transferprocess/TransferProcessHttpClient.java 83.33% <0.00%> (+3.33%) ⬆️
...pse/edc/connector/core/base/EdcHttpClientImpl.java 75.00% <80.00%> (+3.12%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@paullatzelsperger paullatzelsperger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea, we just need to careful when to use it an when not to, because if the runtime "survives" multiple test runs, we could potentially have leftover data in the (inmem) databases.

@ndr-brt ndr-brt merged commit 4226b45 into eclipse-edc:main Sep 13, 2023
23 checks passed
@ndr-brt ndr-brt deleted the 3442-speed-up-e2e-tests branch September 13, 2023 07:27
ndkrimbacher pushed a commit to nexyo-io/DataSpaceConnector that referenced this pull request Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Anything related to the CI/CD Pipeline on Github Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

speed up E2E transfer tests
3 participants