feat(Pool): autovacuum fix + refactor #3479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolf4ood
added
bug
wolf4ood
force-pushed
the
fix/3475_autovacuum
branch
from
74cb1b7
to
06dbdce
Compare
jimmarino
approved these changes
Sep 27, 2023
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3479 +/- ##
==========================================
+ Coverage 71.72% 72.07% +0.34%
==========================================
Files 841 842 +1
Lines 17009 17020 +11
Branches 953 953
==========================================
+ Hits 12200 12267 +67
+ Misses 4406 4349 -57
- Partials 403 404 +1
☔ View full report in Codecov by Sentry. |
wolf4ood
requested review from
ndr-brt and
paullatzelsperger
as code owners
ndr-brt
approved these changes
Sep 27, 2023
wolf4ood
force-pushed
the
fix/3475_autovacuum
branch
from
458203c
to
0752727
Compare
ndkrimbacher
pushed a commit
to nexyo-io/DataSpaceConnector
that referenced
this pull request
Oct 4, 2023
* feat(Pool): disable test connection on return, adds rollback if it's not autocommit, config refactor * docs: adds new pool configuration values in README.md * feat: removes types with var
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
In this PR:
CommonsConnectionPoolServiceExtensionTestwith a functioning oneWhy it does that
cleanup and bug fix for autovacuum
Linked Issue(s)
Closes #3475
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.