refactor: cleanup deprecated code #3489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
requested review from
paullatzelsperger,
bscholtes1A,
ronjaquensel,
juliapampus and
jimmarino
as code owners
ndr-brt
force-pushed
the
3488-cleanup-deprecated-code
branch
from
fc80879
to
535bb3d
Compare
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3489 +/- ##
==========================================
+ Coverage 72.08% 72.12% +0.04%
==========================================
Files 841 829 -12
Lines 16996 16799 -197
Branches 951 943 -8
==========================================
- Hits 12251 12116 -135
+ Misses 4341 4282 -59
+ Partials 404 401 -3
☔ View full report in Codecov by Sentry. |
ndr-brt
force-pushed
the
3488-cleanup-deprecated-code
branch
2 times, most recently
from
42652e4
to
c00b422
Compare
ndr-brt
force-pushed
the
3488-cleanup-deprecated-code
branch
from
c00b422
to
5d0cf90
Compare
jimmarino
approved these changes
Oct 2, 2023
ndkrimbacher
pushed a commit
to nexyo-io/DataSpaceConnector
that referenced
this pull request
Oct 4, 2023
ndr-brt
added
the
breaking-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Remove code that was deprecated in
0.1.xWhy it does that
cleanup
Further notes
oauth-dapsas there's no alternative implemented.Linked Issue(s)
Closes #3488
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.