Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add contractId to EndpointDataReference #3539

Merged
merged 1 commit into from Oct 13, 2023

Conversation

bscholtes1A
Copy link
Contributor

What this PR changes/adds

Duplicate the content of the cid claim in the access token generated for accessing the Data Plane into a dedicated field of EndpointDataReference.

Why it does that

Prevent collision in the access token if cid claim is already taken.

Linked Issue(s)

Closes #3477

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (12f1275) 72.24% compared to head (e102ce4) 72.38%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3539      +/-   ##
==========================================
+ Coverage   72.24%   72.38%   +0.13%     
==========================================
  Files         863      863              
  Lines       17306    17310       +4     
  Branches      986      986              
==========================================
+ Hits        12502    12529      +27     
+ Misses       4392     4369      -23     
  Partials      412      412              
Files Coverage Δ
...DataAddressToEndpointDataReferenceTransformer.java 83.33% <100.00%> (+0.98%) ⬆️
...lane/proxy/ConsumerPullDataPlaneProxyResolver.java 100.00% <100.00%> (ø)
...dc/spi/types/domain/edr/EndpointDataReference.java 71.42% <85.71%> (+71.42%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bscholtes1A bscholtes1A merged commit aa45388 into eclipse-edc:main Oct 13, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EDR: add additional field contractId to hold the contract ID
4 participants