fix: Disable jetty server version #3542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3542 +/- ##
=======================================
Coverage 72.46% 72.46%
=======================================
Files 864 864
Lines 17364 17365 +1
Branches 988 988
=======================================
+ Hits 12582 12583 +1
Misses 4370 4370
Partials 412 412
☔ View full report in Codecov by Sentry. |
jimmarino
requested changes
Oct 14, 2023
extensions/common/http/jetty-core/src/main/java/org/eclipse/edc/web/jetty/JettyService.java
Outdated
Show resolved
Hide resolved
extensions/common/http/jetty-core/src/main/java/org/eclipse/edc/web/jetty/JettyService.java
Outdated
Show resolved
Hide resolved
wolf4ood
added
enhancement
jimmarino
approved these changes
Oct 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
In the
JettyServiceclass I have adjusted theHttpConnectionFactoryand disabled the Jetty server version via theHttpConfiguration.Why it does that
As mentioned in #3415, this issue can lead to a potential attacker finding a vulnerability in Jetty more quickly.
Linked Issue(s)
Closes #3415