Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Standalone STS #3556

Merged
merged 7 commits into from
Oct 25, 2023
Merged

Conversation

wolf4ood
Copy link
Contributor

@wolf4ood wolf4ood commented Oct 20, 2023

What this PR changes/adds

Implements the self-contained version of STS.

In this PR:

The module :extensions:common:iam:identity-trust:identity-trust-sts is created for all STS extensions:

  • identity-trust-sts-api API for minting tokens
  • identity-trust-sts-client-configuration file based StsClients configuration (testing/simple use case)

To be moved in a subsequent PR into :extensions:common:iam:identity-trust:identity-trust-sts

  • identity-trust-sts-core
  • identity-trust-sts-embedded

Additionally a sample launcher in launchers/sts-server is created for playing with the STS standalone.

Additional modules are created for E2E testing of the STS in system-tests:sts-api

Why it does that

iatp adoption

Linked Issue(s)

Closes #3499

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@wolf4ood wolf4ood self-assigned this Oct 20, 2023
@wolf4ood wolf4ood added enhancement New feature or request core feature dcp labels Oct 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (0afa286) 72.28% compared to head (6b1f608) 72.45%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3556      +/-   ##
==========================================
+ Coverage   72.28%   72.45%   +0.16%     
==========================================
  Files         880      887       +7     
  Lines       17724    17846     +122     
  Branches     1022     1023       +1     
==========================================
+ Hits        12812    12930     +118     
- Misses       4476     4480       +4     
  Partials      436      436              
Files Coverage Δ
...ts/core/defaults/service/StsClientServiceImpl.java 100.00% <100.00%> (ø)
...ts/service/StsClientTokenGeneratorServiceImpl.java 100.00% <100.00%> (ø)
...tor/api/sts/configuration/StsApiConfiguration.java 100.00% <100.00%> (ø)
...ts/controller/SecureTokenServiceApiController.java 100.00% <100.00%> (ø)
...tor/api/sts/exception/StsTokenExceptionMapper.java 100.00% <100.00%> (ø)
...connector/api/sts/model/StsTokenErrorResponse.java 100.00% <ø> (ø)
...e/edc/connector/api/sts/model/StsTokenRequest.java 100.00% <100.00%> (ø)
.../edc/connector/api/sts/model/StsTokenResponse.java 100.00% <ø> (ø)
...r/api/sts/validation/StsTokenRequestValidator.java 100.00% <100.00%> (ø)
...nector/api/sts/SecureTokenServiceApiExtension.java 80.00% <80.00%> (ø)
... and 4 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wolf4ood wolf4ood force-pushed the feat/3499_standalone_sts branch 10 times, most recently from b06b0b5 to 2a331e0 Compare October 23, 2023 15:56
@wolf4ood wolf4ood marked this pull request as ready for review October 23, 2023 16:28
launchers/sts-server/build.gradle.kts Outdated Show resolved Hide resolved
launchers/sts-server/certs/key.pem Outdated Show resolved Hide resolved
settings.gradle.kts Outdated Show resolved Hide resolved
settings.gradle.kts Outdated Show resolved Hide resolved
launchers/sts-server/README.md Outdated Show resolved Hide resolved
@wolf4ood wolf4ood merged commit 8f58ce8 into eclipse-edc:main Oct 25, 2023
17 checks passed
@wolf4ood wolf4ood deleted the feat/3499_standalone_sts branch October 25, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IATP: implement self-contained STS
5 participants