Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make DataAddressValidator extend Validator #3561

Merged
merged 1 commit into from Oct 24, 2023

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Oct 24, 2023

What this PR changes/adds

Preparation refactor for issue #3557 , makes DataAddressValidator to extend Validator

Why it does that

modeling

Further notes

Linked Issue(s)

Part of #3557

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added the refactoring Cleaning up code and dependencies label Oct 24, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (27b2cb5) 72.49% compared to head (2e7a663) 72.49%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3561   +/-   ##
=======================================
  Coverage   72.49%   72.49%           
=======================================
  Files         877      877           
  Lines       17474    17475    +1     
  Branches      994      994           
=======================================
+ Hits        12667    12668    +1     
  Misses       4391     4391           
  Partials      416      416           
Files Coverage Δ
...nnector/service/ControlPlaneServicesExtension.java 100.00% <ø> (ø)
.../edc/connector/service/asset/AssetServiceImpl.java 97.77% <ø> (ø)
.../service/dataaddress/DataAddressValidatorImpl.java 100.00% <100.00%> (ø)
...ferprocess/TransferProcessProtocolServiceImpl.java 98.91% <ø> (ø)
...ce/transferprocess/TransferProcessServiceImpl.java 89.47% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wolf4ood wolf4ood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ndr-brt ndr-brt merged commit e90ff5e into eclipse-edc:main Oct 24, 2023
20 checks passed
@ndr-brt ndr-brt deleted the 3557-pre-refactoring branch October 24, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Cleaning up code and dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants