Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remote Secure Token Service #3569

Merged
merged 4 commits into from Oct 30, 2023

Conversation

wolf4ood
Copy link
Contributor

@wolf4ood wolf4ood commented Oct 26, 2023

What this PR changes/adds

Implements a remote version of SecureTokenService using OAuth2 client credentials flow.

Why it does that

iatp adotpion

Further notes

Additionally modules:

  • identity-trust-sts-core
  • identity-trust-sts-embedded

are moved into :extensions:common:iam:identity-trust:identity-trust-sts

Linked Issue(s)

Closes #3564

@wolf4ood wolf4ood self-assigned this Oct 26, 2023
@wolf4ood wolf4ood added core feature iatp enhancement New feature or request labels Oct 26, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (6d8937d) 72.45% compared to head (b3e225e) 72.52%.
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3569      +/-   ##
==========================================
+ Coverage   72.45%   72.52%   +0.07%     
==========================================
  Files         887      891       +4     
  Lines       17846    17917      +71     
  Branches     1023     1024       +1     
==========================================
+ Hits        12930    12995      +65     
- Misses       4480     4485       +5     
- Partials      436      437       +1     
Files Coverage Δ
...tytrust/validation/SelfIssuedIdTokenValidator.java 92.30% <ø> (-0.80%) ⬇️
...ts/controller/SecureTokenServiceApiController.java 100.00% <100.00%> (ø)
...itytrust/sts/core/StsDefaultServicesExtension.java 71.42% <ø> (ø)
...ntitytrust/sts/core/StsDefaultStoresExtension.java 66.66% <ø> (ø)
...ts/core/defaults/service/StsClientServiceImpl.java 100.00% <ø> (ø)
...ts/service/StsClientTokenGeneratorServiceImpl.java 100.00% <100.00%> (ø)
...ts/core/defaults/store/InMemoryStsClientStore.java 100.00% <ø> (ø)
...trust/sts/embedded/EmbeddedSecureTokenService.java 100.00% <100.00%> (ø)
...tytrust/sts/embedded/SelfIssuedTokenDecorator.java 100.00% <ø> (ø)
...titytrust/sts/remote/RemoteSecureTokenService.java 100.00% <100.00%> (ø)
... and 4 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wolf4ood wolf4ood force-pushed the feat/3564_remote_sts branch 11 times, most recently from ca9c7a9 to b3e225e Compare October 27, 2023 15:29
@wolf4ood wolf4ood marked this pull request as ready for review October 27, 2023 15:47
@wolf4ood wolf4ood merged commit 47313c0 into eclipse-edc:main Oct 30, 2023
17 checks passed
@wolf4ood wolf4ood deleted the feat/3564_remote_sts branch October 30, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IATP: implement remote STS
4 participants