refactor: make DataPlanePublicApiController use PipelineService #3630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bscholtes1A
approved these changes
Nov 20, 2023
| @@ -67,6 +65,9 @@ public class DataPlaneApiExtension implements ServiceExtension { | |||
| @Inject | |||
| private DataPlaneManager dataPlaneManager; | |||
There was a problem hiding this comment.
no, because it is used by DataPlaneControlApiController
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3630 +/- ##
==========================================
- Coverage 71.78% 71.68% -0.10%
==========================================
Files 909 909
Lines 18134 18127 -7
Branches 1033 1032 -1
==========================================
- Hits 13018 12995 -23
- Misses 4672 4688 +16
Partials 444 444 ☔ View full report in Codecov by Sentry. |
ndr-brt
force-pushed
the
3629-make-public-controller-use-pipeline-service
branch
from
e521590
to
8a2aa3e
Compare
jimmarino
approved these changes
Nov 20, 2023
wolf4ood
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Make
DataPlanePublicApiControllergo directly throughPipelineServiceinstead of passing throughDataPlaneManagerWhy it does that
avoid useless indirection
Further notes
Linked Issue(s)
Closes #3629
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.