Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: separate DataPlaneClient and DataPlaneSelector #3641

Merged

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Nov 22, 2023

What this PR changes/adds

extract selection feature from the DataPlaneClient component

Why it does that

preparatory refactoring for the issue #3631 , this way the DataPlaneSelectorService is directly used by the ProviderPushTransferDataFlowController that can use it to get the available transfer types. This way there's also a match with the ConsumerPullTransferDataFlowController, that also has the selector service as collaborator.

Further notes

  • inlined the DataPlaneSelectorClient into the DataPlaneSelectorService, as they were doing the same thing. now the EmbeddedDataPlaneSelectorClient is the default implementation used by the api controller, and the Remote implementation can be used whenever the selector is deployed separately through the client module.
  • inlined DataPlaneSelector as well, as it was doing nothing that couldn't be done easily by the EmbeddedDataPlaneSelectorService

Linked Issue(s)

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added the refactoring Cleaning up code and dependencies label Nov 22, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2023

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (a3ef0f1) 71.81% compared to head (6255da3) 71.82%.

Files Patch % Lines
...ava/org/eclipse/edc/spi/response/StatusResult.java 0.00% 6 Missing ⚠️
...tor/DataPlaneSelectorDefaultServicesExtension.java 0.00% 3 Missing ⚠️
...dataplane/selector/DataPlaneSelectorExtension.java 0.00% 2 Missing ⚠️
...plane/selector/RemoteDataPlaneSelectorService.java 86.66% 2 Missing ⚠️
...nector/dataplane/client/RemoteDataPlaneClient.java 81.81% 2 Missing ⚠️
...taplane/selector/spi/DataPlaneSelectorService.java 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3641      +/-   ##
==========================================
+ Coverage   71.81%   71.82%   +0.01%     
==========================================
  Files         917      914       -3     
  Lines       18395    18375      -20     
  Branches     1044     1042       -2     
==========================================
- Hits        13210    13198      -12     
+ Misses       4726     4717       -9     
- Partials      459      460       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndr-brt ndr-brt force-pushed the 3631-distribution-instantiation branch from 4d8ea3c to 6255da3 Compare November 27, 2023 08:46
@ndr-brt ndr-brt merged commit cd0f8eb into eclipse-edc:main Nov 27, 2023
17 checks passed
@ndr-brt ndr-brt deleted the 3631-distribution-instantiation branch November 27, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Cleaning up code and dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants