Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create pluggable CredentialService url resolver #3654

Conversation

paullatzelsperger
Copy link
Member

@paullatzelsperger paullatzelsperger commented Nov 24, 2023

What this PR changes/adds

This PR adds a pluggable CredentialServiceUrlResolver, whos job it is to take an issuer, and resolve its CredentialService URL.
The default implementation in IATP for this will be a DidCredentialServiceUrlResolver, that interprets the issuer as DID and
resolves the DID, which is expected to contain a CredentialService endpoint entry.

Why it does that

The relying party (RP) needs to be able to resolve the counter-party's CredentialService to obtain VCs.

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes #3647

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@paullatzelsperger paullatzelsperger added this to the Milestone 13 milestone Nov 24, 2023
@paullatzelsperger paullatzelsperger added enhancement New feature or request iatp labels Nov 24, 2023
@paullatzelsperger paullatzelsperger force-pushed the feat/3647_pluggable_credentialServiceUrlResolver branch from edc3b3a to f3f2954 Compare November 24, 2023 08:18
@paullatzelsperger paullatzelsperger force-pushed the feat/3647_pluggable_credentialServiceUrlResolver branch from f3f2954 to bfb2759 Compare November 24, 2023 08:22
@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (906bc17) 71.74% compared to head (f2a8bfd) 71.76%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3654      +/-   ##
==========================================
+ Coverage   71.74%   71.76%   +0.02%     
==========================================
  Files         915      916       +1     
  Lines       18342    18356      +14     
  Branches     1040     1041       +1     
==========================================
+ Hits        13159    13173      +14     
  Misses       4727     4727              
  Partials      456      456              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paullatzelsperger paullatzelsperger merged commit 66ded5e into eclipse-edc:main Nov 24, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request iatp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create pluggable credentialServiceUrl resolver
3 participants