Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: various minor improvements / patches for IATP #3660

Conversation

paullatzelsperger
Copy link
Member

@paullatzelsperger paullatzelsperger commented Nov 26, 2023

What this PR changes/adds

This PR adds several minor features and fixes for IATP:

  • extracts a ClaimToken from a VC
  • performs URI comparison without fragment when comparing Issuer and VerificationMethod
  • fixes a wrong extracton of DID#VerificationMethod.controller and DID#VerificationMethod.type
  • adds a customizable accumulator operation to the predicate-based query resolver

Why it does that

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes #3650

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@paullatzelsperger paullatzelsperger added this to the Milestone 13 milestone Nov 26, 2023
@paullatzelsperger paullatzelsperger added bug Something isn't working iatp labels Nov 26, 2023
@paullatzelsperger paullatzelsperger force-pushed the fix/various_smaller_fixes_for_iatp2 branch 3 times, most recently from 3f9316c to 2e94ad4 Compare November 26, 2023 17:33
@paullatzelsperger paullatzelsperger force-pushed the fix/various_smaller_fixes_for_iatp2 branch from 2e94ad4 to 1167c72 Compare November 26, 2023 17:34
@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2023

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (a3ef0f1) 71.81% compared to head (ef827f1) 71.80%.
Report is 2 commits behind head on main.

Files Patch % Lines
...edc/iam/identitytrust/IdentityAndTrustService.java 11.11% 8 Missing ⚠️
...JsonObjectToVerifiablePresentationTransformer.java 66.66% 0 Missing and 2 partials ⚠️
...ust/model/credentialservice/PresentationQuery.java 0.00% 2 Missing ⚠️
...ector/core/store/ReflectionBasedQueryResolver.java 66.66% 0 Missing and 1 partial ⚠️
...c/main/java/org/eclipse/edc/util/uri/UriUtils.java 83.33% 1 Missing ⚠️
...iablecredentials/linkeddata/DidMethodResolver.java 0.00% 1 Missing ⚠️
.../java/org/eclipse/edc/spi/query/QueryResolver.java 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3660      +/-   ##
==========================================
- Coverage   71.81%   71.80%   -0.02%     
==========================================
  Files         917      916       -1     
  Lines       18395    18388       -7     
  Branches     1044     1042       -2     
==========================================
- Hits        13210    13203       -7     
+ Misses       4726     4725       -1     
- Partials      459      460       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paullatzelsperger paullatzelsperger marked this pull request as ready for review November 27, 2023 11:22
Copy link
Contributor

@wolf4ood wolf4ood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paullatzelsperger paullatzelsperger merged commit 0fc2e34 into eclipse-edc:main Nov 28, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working iatp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LDP VC/VP Verification: create URI-equality comparison that ignores the fragment
3 participants