Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor move DspRequestHandlerImpl #3663

Merged

Conversation

wolf4ood
Copy link
Contributor

What this PR changes/adds

  • move DspRequestHandlerImpl into dsp-http-core module.
  • move DspErrorResponse into dsp-http-spi module.

Why it does that

preparatory refactor for #3662

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@wolf4ood wolf4ood self-assigned this Nov 27, 2023
@wolf4ood wolf4ood added iatp refactoring Cleaning up code and dependencies and removed iatp labels Nov 27, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cd0f8eb) 71.82% compared to head (10c0f60) 71.67%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3663      +/-   ##
==========================================
- Coverage   71.82%   71.67%   -0.16%     
==========================================
  Files         914      914              
  Lines       18375    18375              
  Branches     1042     1042              
==========================================
- Hits        13198    13170      -28     
- Misses       4717     4746      +29     
+ Partials      460      459       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wolf4ood wolf4ood marked this pull request as ready for review November 27, 2023 12:06
@wolf4ood wolf4ood merged commit ad100a6 into eclipse-edc:main Nov 28, 2023
20 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Cleaning up code and dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants