feat: query policydefinition, contractdefinition via privateProperties #3691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ition_via_properties
…ition_via_properties
…ition_via_properties' into feat/search_policy_contractdefinition_via_properties
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3691 +/- ##
==========================================
+ Coverage 71.74% 71.75% +0.01%
==========================================
Files 919 921 +2
Lines 18457 18477 +20
Branches 1037 1039 +2
==========================================
+ Hits 13242 13259 +17
- Misses 4756 4757 +1
- Partials 459 461 +2 ☔ View full report in Codecov by Sentry. |
…ition_via_properties
…ition_via_properties' into feat/search_policy_contractdefinition_via_properties
|
can label be assigned to this PR?. Apart from that PR is ready. Unit test, endtoend tests are there for query. |
…ition_via_properties' into feat/search_policy_contractdefinition_via_properties
ndr-brt
requested changes
Dec 21, 2023
...aggregate-services/src/main/java/org/eclipse/edc/connector/service/query/QueryValidator.java
Outdated
Show resolved
Hide resolved
core/control-plane/control-plane-aggregate-services/build.gradle.kts
Outdated
Show resolved
Hide resolved
...java/org/eclipse/edc/connector/service/policydefinition/PolicyDefinitionServiceImplTest.java
Show resolved
Hide resolved
...java/org/eclipse/edc/connector/service/policydefinition/PolicyDefinitionServiceImplTest.java
Show resolved
Hide resolved
ndr-brt
approved these changes
Dec 22, 2023
...aggregate-services/src/main/java/org/eclipse/edc/connector/service/query/QueryValidator.java
Show resolved
Hide resolved
…ition_via_properties
jimmarino
reviewed
Dec 29, 2023
core/control-plane/control-plane-aggregate-services/build.gradle.kts
Outdated
Show resolved
Hide resolved
jimmarino
reviewed
Dec 29, 2023
...aggregate-services/src/main/java/org/eclipse/edc/connector/service/query/QueryValidator.java
Show resolved
Hide resolved
jimmarino
reviewed
Dec 29, 2023
jimmarino
reviewed
Dec 29, 2023
...er/src/test/java/org/eclipse/edc/test/e2e/managementapi/PolicyDefinitionApiEndToEndTest.java
Show resolved
Hide resolved
|
@jimmarino Please check it |
…ition_via_properties
Check what? If you want me to re-review the PR, please resolve the open issues and re-request the review. |
I already resolved last 4 review comments you have given. @ndr-brt approved PR. If all ok for you, please approve. |
|
Please resolve the outstanding conversations and I will take another look. |
resolved. |
jimmarino
requested changes
Jan 9, 2024
...aggregate-services/src/main/java/org/eclipse/edc/connector/service/query/QueryValidator.java
Outdated
Show resolved
Hide resolved
...aggregate-services/src/main/java/org/eclipse/edc/connector/service/query/QueryValidator.java
Outdated
Show resolved
Hide resolved
...egate-services/src/test/java/org/eclipse/edc/connector/service/query/QueryValidatorTest.java
Outdated
Show resolved
Hide resolved
...pse/edc/connector/contract/spi/testfixtures/offer/store/ContractDefinitionStoreTestBase.java
Outdated
Show resolved
Hide resolved
...pse/edc/connector/contract/spi/testfixtures/offer/store/ContractDefinitionStoreTestBase.java
Outdated
Show resolved
Hide resolved
...pse/edc/connector/contract/spi/testfixtures/offer/store/ContractDefinitionStoreTestBase.java
Outdated
Show resolved
Hide resolved
...pse/edc/connector/contract/spi/testfixtures/offer/store/ContractDefinitionStoreTestBase.java
Show resolved
Hide resolved
...a/org/eclipse/edc/connector/policy/spi/testfixtures/store/PolicyDefinitionStoreTestBase.java
Show resolved
Hide resolved
jimmarino
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Search policydefinition, contractdefinition via privateProperties
Why it does that
PrivateProperties are stored in policydefinition, contractdefinition as json values. It is necessary to support search/query function via these stored json values.
Linked Issue(s)
Closes #3623