Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unused references and dead code #3707

Merged
merged 3 commits into from Dec 12, 2023

Conversation

jimmarino
Copy link
Contributor

@jimmarino jimmarino commented Dec 12, 2023

What this PR changes/adds

Removes unused references and dead code in the DSP modules.

Linked Issue(s)

Closes #3706

@jimmarino jimmarino added the refactoring Cleaning up code and dependencies label Dec 12, 2023
Copy link
Member

@paullatzelsperger paullatzelsperger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪓

Copy link
Member

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪓

@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c6d378d) 71.74% compared to head (58e9da1) 71.74%.

Files Patch % Lines
...patcher/DspNegotiationHttpDispatcherExtension.java 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3707   +/-   ##
=======================================
  Coverage   71.74%   71.74%           
=======================================
  Files         919      919           
  Lines       18458    18457    -1     
  Branches     1037     1037           
=======================================
  Hits        13242    13242           
+ Misses       4757     4756    -1     
  Partials      459      459           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jimmarino jimmarino merged commit 3b70f4f into eclipse-edc:main Dec 12, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Cleaning up code and dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: Remove dead code and unused references in the DSP modules
5 participants