Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: timeout and protocol configurable in Participant #3753

Merged

Conversation

wolf4ood
Copy link
Contributor

@wolf4ood wolf4ood commented Jan 2, 2024

What this PR changes/adds

Adds configurable timeout and protocol in Participant

Why it does that

Extensibility/reusability

Further notes

This PR also adds additional methods that can be useful when doing E2E tests:

  • getCatalogDatasets with a query
  • initContractNegotiation with asset id or a policy (just starts the contract negotiation)
  • getTransferProcesses get transfer process with an optional query
  • getContractNegotiationState get the state of a contract negotiaion

Since those method matching management APIs could grow. In subsequent PRs I'd suggest to start splitting those method in contexts.

For example something like this:

Participant#transferProcesses all methods related to transfer processes
Participant#negotiations all methods related to contract negotiation
Participant#catalog all methods related to catalog
...etc

Linked Issue(s)

Closes #3752

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@wolf4ood wolf4ood force-pushed the feat/3752_participant_improvements branch from 40ba3ea to f187f35 Compare January 2, 2024 14:21
@wolf4ood wolf4ood self-assigned this Jan 2, 2024
@wolf4ood wolf4ood added the enhancement New feature or request label Jan 2, 2024
@wolf4ood wolf4ood marked this pull request as ready for review January 2, 2024 14:49
@wolf4ood wolf4ood changed the title feat: timeout and protocol configurable in Participants + additional … feat: timeout and protocol configurable in Participants Jan 2, 2024
@wolf4ood wolf4ood changed the title feat: timeout and protocol configurable in Participants feat: timeout and protocol configurable in Participant Jan 2, 2024
@wolf4ood wolf4ood merged commit 70992d8 into eclipse-edc:main Jan 2, 2024
24 of 27 checks passed
@wolf4ood wolf4ood deleted the feat/3752_participant_improvements branch January 2, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E Participant: configurable timeout
2 participants