refactor: get rid of DspHttpDispatcherDelegate #3771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
requested review from
paullatzelsperger,
ronjaquensel,
juliapampus and
jimmarino
as code owners
jimmarino
approved these changes
Jan 11, 2024
...rc/main/java/org/eclipse/edc/protocol/dsp/dispatcher/DspHttpRemoteMessageDispatcherImpl.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/eclipse/edc/protocol/dsp/dispatcher/DspHttpRemoteMessageDispatcherImpl.java
Outdated
Show resolved
Hide resolved
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
.../java/org/eclipse/edc/protocol/dsp/spi/dispatcher/response/DspHttpResponseBodyExtractor.java
Fixed
Show fixed
Hide fixed
ndr-brt
force-pushed
the
3344-refactor-dsp-delegates
branch
from
3824144
to
30177cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Get rid of DspHttpDispatcherDelegate and subclasses, preferring composition over inheritance.
Why it does that
cleanup
Further notes
EdcHttpClient.executeAsyncmethods as they are not really needed, in fact have the mapping function passed to the method makes really hard to test, plus having an overarchingresponseclosure is not the best approach because if the body is null that will end up with an exception. (is theResponseBodythat needs to be closed, please refer to the way it was handled in theDspHttpRemoteMessageDispatcherImpl.handleResponsemethod.Linked Issue(s)
Closes #3344
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.