Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: align DCAT namespace IRI to the correct one #3781

Merged
merged 1 commit into from Jan 17, 2024

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Jan 17, 2024

What this PR changes/adds

Fix the DCAT namespace IRI according to the documentation (https://www.w3.org/TR/vocab-dcat-3/#normative-namespaces)

Why it does that

dcat compliance

Further notes

  • this is a breaking change because the Catalog will be expanded in a different way than before. No issue on persistance because we don't store anything related to DCAT.

Linked Issue(s)

Closes #3458

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added bug Something isn't working api Feature related to the (REST) api breaking-change Will require manual intervention for version update labels Jan 17, 2024
Copy link
Contributor

@ronjaquensel ronjaquensel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The entry "dcat": "https://www.w3.org/ns/dcat/" is also in the CatalogSchema and DatasetSchema examples in the CatalogApi class.

@ndr-brt ndr-brt merged commit a195712 into eclipse-edc:main Jan 17, 2024
17 checks passed
@ndr-brt ndr-brt deleted the 3458-fix-dcat-namespace-iri branch January 17, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Feature related to the (REST) api breaking-change Will require manual intervention for version update bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON-LD "@context" using slightly different URLs than DCAT3
3 participants