feat: update to the latest IATP changes #3805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
.../java/org/eclipse/edc/identitytrust/model/credentialservice/PresentationResponseMessage.java
Fixed
Show fixed
Hide fixed
wolf4ood
force-pushed
the
feat/3803_iatp_changes
branch
2 times, most recently
from
2a1c8b2
to
b8cf15d
Compare
wolf4ood
force-pushed
the
feat/3803_iatp_changes
branch
5 times, most recently
from
4d82cd5
to
6b2f148
Compare
wolf4ood
force-pushed
the
feat/3803_iatp_changes
branch
from
6b2f148
to
36ade72
Compare
jimmarino
requested changes
Jan 26, 2024
| public static final String PRESENTATION_RESPONSE_MESSAGE_PRESENTATION_SUBMISSION_PROPERTY = IATP_PREFIX + "presentationSubmission"; | ||
| public static final String PRESENTATION_RESPONSE_MESSAGE_TYPE_PROPERTY = IATP_PREFIX + "PresentationResponseMessage"; | ||
|
|
||
| private Object[] presentation = new Object[0]; |
There was a problem hiding this comment.
Can we change this to a List?
jimmarino
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Align with the latest changes in the resolution api protocol
PresentationQuerytoPresentationQueryMessagePresentationResponsetoPresentationResponseMessagePresentationResponseMessagewith transformers from/to JsonObjectDefaultCredentialServiceClientnow parses the JSON-LD response forPresentationResponseMessageiatpcontextLinked Issue(s)
Closes #3803
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.