feat: add operators validation #3809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
added
enhancement
ndr-brt
requested review from
paullatzelsperger,
ronjaquensel,
juliapampus and
jimmarino
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...ommon/connector-core/src/main/java/org/eclipse/edc/connector/core/CoreServicesExtension.java
Fixed
Show fixed
Hide fixed
ndr-brt
force-pushed
the
3713-add-operators-validator
branch
from
0749aa5
to
5d78f71
Compare
|
This pull request is stale because it has been open for 7 days with no activity. |
paullatzelsperger
approved these changes
Feb 6, 2024
| @Override | ||
| public boolean test(Object property, Object operandRight) { | ||
| if (property instanceof Collection<?> collection) { | ||
| return collection.contains(operandRight); |
There was a problem hiding this comment.
theoretically operandRight could be a List itself, IDK what would happen then...
There was a problem hiding this comment.
in the (postgre)SQL context it can be only a single object, because eventually I guess another operator/syntax would need to be used.
I think if we want to being able to pass a list as operandRight we'll need another operator (containsAll?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Add operator validation.
Why it does that
avoid problems with unsupported operators upfront
Further notes
Predicate, this way it will be possible for adopters to implement custom operators with custom validation. theCriterionOperatorRegistrykeeps track of the supported operators and the way to translate aCriterioninto aPredicate.Linked Issue(s)
Closes #3713
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.