feat: avoid fetching body in memory during data plane proxy call #3827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
force-pushed
the
3826-optimize-outputstreamdatasink
branch
4 times, most recently
from
385848a
to
da753e5
Compare
ndr-brt
force-pushed
the
3826-optimize-outputstreamdatasink
branch
from
da753e5
to
0680685
Compare
jimmarino
approved these changes
Feb 6, 2024
bscholtes1A
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Use the
AsyncStreamingDataSinkin theDataPlanePublicApiController, to avoid buffering response body in memory.Why it does that
optimization, permit long-running calls
Further notes
Linked Issue(s)
Closes #3826
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.