Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: introduction of ProtocolTokenValidator #3839

Merged

Conversation

wolf4ood
Copy link
Contributor

@wolf4ood wolf4ood commented Feb 9, 2024

What this PR changes/adds

  • Extracts BaseProtocolService into ProtocolTokenValidator
  • Removes the parsing of access_token for fetching the scopes
  • Removes the deprecated VerificationContext#audience field

Why it does that

refactoring

Linked Issue(s)

Closes #3832

@wolf4ood wolf4ood force-pushed the feat/3832_base_protocol_service_refactor branch from 757a44b to 80aaf51 Compare February 9, 2024 07:48
@wolf4ood wolf4ood self-assigned this Feb 9, 2024
@wolf4ood wolf4ood added the refactoring Cleaning up code and dependencies label Feb 9, 2024
@wolf4ood wolf4ood force-pushed the feat/3832_base_protocol_service_refactor branch from 80aaf51 to 8997234 Compare February 9, 2024 09:02
@wolf4ood wolf4ood force-pushed the feat/3832_base_protocol_service_refactor branch from 8997234 to 939cfbe Compare February 9, 2024 14:36
@wolf4ood wolf4ood marked this pull request as ready for review February 9, 2024 15:17
Copy link
Member

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wolf4ood wolf4ood merged commit 8193f3d into eclipse-edc:main Feb 9, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Cleaning up code and dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor BaseProtocolService into ProtocolTokenValidator spi
3 participants