Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: attach entire VC to claimtoken #3856

Conversation

paullatzelsperger
Copy link
Member

What this PR changes/adds

This PR changes, what the ClaimtToken contains when the IdentityAndTrustService creates it.
Before, it only contained the credentialSubject of each VC, where now it contains the actual list of VCs.

This is also pluggable, with a default implementation.

Why it does that

More versatile ways to evaluate the ClaimToken in policy evaluation functions.

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes #3855

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@paullatzelsperger paullatzelsperger added this to the Milestone 14 milestone Feb 13, 2024
@paullatzelsperger paullatzelsperger added enhancement New feature or request iatp labels Feb 13, 2024
@paullatzelsperger paullatzelsperger self-assigned this Feb 13, 2024
@paullatzelsperger paullatzelsperger merged commit 0634f02 into eclipse-edc:main Feb 14, 2024
17 checks passed
@paullatzelsperger paullatzelsperger deleted the feat/3855_iatp_attach_vc_to_claimtoken branch February 14, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request iatp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IATP: attach the entire VerifiableCredential to the ClaimToken
2 participants