Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing ParticipantAgentExtension in IdentityAndTrustExtension #3888

Merged

Conversation

bscholtes1A
Copy link
Contributor

@bscholtes1A bscholtes1A commented Feb 21, 2024

What this PR changes/adds

This PR registers a ParticipantAgentExtension in the IdentityAndTrustExtension that sets the ParticipantAgent.PARTICIPANT_IDENTITY attributes.

Without this attribute, all contract validations are failing (for example here as the ParticipantAgent.getIdentity() method would return null.

Why it does that

Enable proper contract validation when using IdentityAndTrustExtension.

Further notes

Also takes opportunity of this PR to add the missing counterPartyId in the catalog requests of the Participant fixture.

Linked Issue(s)

Closes # <-- insert Issue number if one exists

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@bscholtes1A bscholtes1A added bug Something isn't working iatp labels Feb 21, 2024
@bscholtes1A bscholtes1A requested review from ndr-brt and paullatzelsperger and removed request for paullatzelsperger February 21, 2024 10:59
Copy link
Contributor

@wolf4ood wolf4ood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this extension optional? In dataspaces that are not using the did as participant id the identity extractor might
not be this one but a custom one

@bscholtes1A bscholtes1A force-pushed the fix/iatp_participant_agent_extension branch from 6aa1d06 to 7afcb65 Compare February 21, 2024 12:43
@bscholtes1A
Copy link
Contributor Author

Can we make this extension optional? In dataspaces that are not using the did as participant id the identity extractor might not be this one but a custom one

Done, could you please review latest changes?

@bscholtes1A bscholtes1A merged commit 34c3285 into eclipse-edc:main Feb 21, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working iatp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants