Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dsp): add participantId property on catalog #3916

Merged
merged 1 commit into from Feb 26, 2024

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Feb 23, 2024

What this PR changes/adds

Add the dspace:participantId property on Catalog. The old edc:participantId has been kept and deprecated.

Why it does that

dsp compliance

Further notes

  • the JsonObjectTo... catalog related transformers are actually unused in the whole project so I deleted them as they are dead code.
  • moved the "JsonObjectFrom..." catalog related transformers out of the transformer-core module into the dsp-catalog-transformer module.

Linked Issue(s)

Closes #3880

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added enhancement New feature or request dataspace-protocol related to the dataspace protocol labels Feb 23, 2024
@ndr-brt ndr-brt merged commit 2857d37 into eclipse-edc:main Feb 26, 2024
20 checks passed
@ndr-brt ndr-brt deleted the 3880-participantId-prefix branch February 26, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dataspace-protocol related to the dataspace protocol enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DSP 1.0: Participant id prefix change
2 participants