Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: proxy method on Http Pull calls #3956

Merged
merged 2 commits into from Mar 5, 2024

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Mar 4, 2024

What this PR changes/adds

Fix "proxyMethod" and cover it with a test.

Why it does that

fix bug

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes #3954

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added bug Something isn't working dpf Feature related to the Data Plane Framework labels Mar 4, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.33%. Comparing base (7f20ba5) to head (e6ae238).
Report is 118 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3956      +/-   ##
==========================================
+ Coverage   71.74%   73.33%   +1.58%     
==========================================
  Files         919      958      +39     
  Lines       18457    19255     +798     
  Branches     1037     1089      +52     
==========================================
+ Hits        13242    14120     +878     
+ Misses       4756     4674      -82     
- Partials      459      461       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndr-brt ndr-brt merged commit 19671bc into eclipse-edc:main Mar 5, 2024
17 checks passed
@ndr-brt ndr-brt deleted the 3954-fix-proxy-method branch March 5, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dpf Feature related to the Data Plane Framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EDC 0.5.1 HttpProxy is not being handled correctly
4 participants