feat: add Authorization to the Public API (v2) #3966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
added
enhancement
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...ne/data-plane-spi/src/main/java/org/eclipse/edc/connector/dataplane/spi/AccessTokenData.java
Dismissed
Show dismissed
Hide dismissed
...ne/data-plane-spi/src/main/java/org/eclipse/edc/connector/dataplane/spi/AccessTokenData.java
Dismissed
Show dismissed
Hide dismissed
...ne/data-plane-spi/src/main/java/org/eclipse/edc/connector/dataplane/spi/AccessTokenData.java
Dismissed
Show dismissed
Hide dismissed
...ne/data-plane-spi/src/main/java/org/eclipse/edc/connector/dataplane/spi/AccessTokenData.java
Dismissed
Show dismissed
Hide dismissed
paullatzelsperger
requested review from
ndr-brt,
bscholtes1A and
jimmarino
as code owners
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3966 +/- ##
==========================================
+ Coverage 71.74% 73.32% +1.57%
==========================================
Files 919 963 +44
Lines 18457 19389 +932
Branches 1037 1094 +57
==========================================
+ Hits 13242 14217 +975
+ Misses 4756 4708 -48
- Partials 459 464 +5 ☔ View full report in Codecov by Sentry. |
ndr-brt
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR adds a new PublicAPI Controller (available under the '/v2' path), that uses the
DataPlaneAuthorizationServiceinstead of the legacyConsumerPullDataPlaneProxyResolver.Since the new public API is in its separate module, there is no breaking change and both APIs can be operated in parallel.
Why it does that
DataPlaneSignaling adoption
Further notes
AccessTokenDataobject now has anadditionalPropertiesfield. Thus, the SQL module and tests were adapted.DataPlanePublicApiControllerLinked Issue(s)
Closes #3958
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.