Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable HTTP pull scenario E2E test with DPS #3988

Merged

Conversation

wolf4ood
Copy link
Contributor

@wolf4ood wolf4ood commented Mar 11, 2024

What this PR changes/adds

enable HTTP pull scenario E2E test with DPS

Why it does that

data plane signaling

Further notes

In DataPlaneSignalingApiController the validation for now it's skipped for PULL scenario (otherwise will fail)
and thus the test start_whenInvalidMessage has been disabled, waiting for #3990

Linked Issue(s)

Closes #3989

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@wolf4ood wolf4ood force-pushed the chore/enable_e2e_http_pull_test_signaling branch from d13cb45 to 11e6f16 Compare March 11, 2024 14:02
@wolf4ood wolf4ood self-assigned this Mar 11, 2024
@wolf4ood wolf4ood added the enhancement New feature or request label Mar 11, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 73.40%. Comparing base (7f20ba5) to head (c2cef93).
Report is 137 commits behind head on main.

Files Patch % Lines
...controller/v1/DataPlaneSignalingApiController.java 16.66% 5 Missing ⚠️
...ramework/DataPlaneDefaultIamServicesExtension.java 0.00% 4 Missing ⚠️
...r/dataplane/api/DataPlanePublicApiV2Extension.java 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3988      +/-   ##
==========================================
+ Coverage   71.74%   73.40%   +1.65%     
==========================================
  Files         919      975      +56     
  Lines       18457    19661    +1204     
  Branches     1037     1105      +68     
==========================================
+ Hits        13242    14432    +1190     
- Misses       4756     4758       +2     
- Partials      459      471      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wolf4ood wolf4ood force-pushed the chore/enable_e2e_http_pull_test_signaling branch 4 times, most recently from 7b9ec4c to 8ea14c0 Compare March 11, 2024 14:59
@wolf4ood wolf4ood marked this pull request as ready for review March 11, 2024 15:36
@wolf4ood wolf4ood force-pushed the chore/enable_e2e_http_pull_test_signaling branch from 8ea14c0 to c2cef93 Compare March 12, 2024 08:21
@wolf4ood wolf4ood merged commit f50e2f2 into eclipse-edc:main Mar 12, 2024
17 checks passed
@wolf4ood wolf4ood deleted the chore/enable_e2e_http_pull_test_signaling branch March 12, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DPS: E2E test with HTTP pull scenario
4 participants