Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implements EDR cache receiver + E2E tests #4004

Merged
merged 3 commits into from Mar 15, 2024

Conversation

wolf4ood
Copy link
Contributor

@wolf4ood wolf4ood commented Mar 13, 2024

What this PR changes/adds

implements EDR cache receiver + E2E tests specifically:

  • adds edr-store-receiver extension that will automatically cache the DataAddress when the transfer process starts on the consumer side. It uses the event mechanism to also keep the cache sync with the transfer status (completed/terminated). With a setting edc.edr.receiver.sync it can be configured to operate in a synchronous way (async by default).
  • The TransferProcessEvent base class for transfer process events has been refactor to host all the common fields for transfer process events like assetId, type and contractId
  • Some refactor around the EndToEndTransferParticipant for E2E test by extracting it to a base class which can be extended for custom/additional use case
  • Added E2E tests for fetching data using the EDR API instead of using remote callbacks for getting access to the EDR associated to the transfer process. This also covers the case of contract expiry, ensuring that the EDR is purged on transfer termination by the PolicyMonitor

Why it does that

data plane signaling

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes #3998

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@wolf4ood wolf4ood self-assigned this Mar 13, 2024
@wolf4ood wolf4ood added the enhancement New feature or request label Mar 13, 2024
@wolf4ood wolf4ood force-pushed the feat/3998_edr_feeder_listener branch from 9ff0302 to 9bb867a Compare March 14, 2024 10:01
@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 79.12088% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 73.59%. Comparing base (7f20ba5) to head (8a7f188).
Report is 144 commits behind head on main.

Files Patch % Lines
...ransfer/listener/TransferProcessEventListener.java 0.00% 14 Missing ⚠️
...e/receiver/EndpointDataReferenceStoreReceiver.java 96.15% 0 Missing and 2 partials ⚠️
...aults/InMemoryEndpointDataReferenceEntryIndex.java 0.00% 1 Missing ⚠️
...core/edr/store/EndpointDataReferenceStoreImpl.java 0.00% 1 Missing ⚠️
...r/EndpointDataReferenceStoreReceiverExtension.java 87.50% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4004      +/-   ##
==========================================
+ Coverage   71.74%   73.59%   +1.85%     
==========================================
  Files         919      978      +59     
  Lines       18457    19757    +1300     
  Branches     1037     1113      +76     
==========================================
+ Hits        13242    14541    +1299     
+ Misses       4756     4741      -15     
- Partials      459      475      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wolf4ood wolf4ood force-pushed the feat/3998_edr_feeder_listener branch 5 times, most recently from 89ab7f2 to aff876d Compare March 14, 2024 12:02
@wolf4ood wolf4ood force-pushed the feat/3998_edr_feeder_listener branch from aff876d to 8a7f188 Compare March 14, 2024 12:13
@wolf4ood wolf4ood marked this pull request as ready for review March 14, 2024 13:05
@wolf4ood wolf4ood merged commit dcac6d3 into eclipse-edc:main Mar 15, 2024
17 checks passed
@wolf4ood wolf4ood deleted the feat/3998_edr_feeder_listener branch March 15, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DPS: EDR store/cache receiver
3 participants