Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add UNAUTHORIZED case label #4014

Conversation

paullatzelsperger
Copy link
Member

What this PR changes/adds

Adds the UNAUTHORIZED case label to the ServiceResultHandler, so exceptions can be properly mapped.

Why it does that

Briefly state why the change was necessary.

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes # <-- insert Issue number if one exists

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@paullatzelsperger paullatzelsperger added the enhancement New feature or request label Mar 18, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 73.59%. Comparing base (7f20ba5) to head (dc428ce).
Report is 148 commits behind head on main.

Files Patch % Lines
...se/edc/web/spi/exception/ServiceResultHandler.java 0.00% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4014      +/-   ##
==========================================
+ Coverage   71.74%   73.59%   +1.85%     
==========================================
  Files         919      978      +59     
  Lines       18457    19754    +1297     
  Branches     1037     1113      +76     
==========================================
+ Hits        13242    14538    +1296     
+ Misses       4756     4741      -15     
- Partials      459      475      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paullatzelsperger paullatzelsperger merged commit 93b88d9 into eclipse-edc:main Mar 18, 2024
17 checks passed
@paullatzelsperger paullatzelsperger deleted the chore/add_unauthorized_case branch March 18, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants