Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dsp): implement transfer resumption #4027

Merged
merged 2 commits into from Mar 27, 2024

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Mar 21, 2024

What this PR changes/adds

Permit to resume a SUSPENDED transfer.
For doing that, in the case is the consumer that resume the transfer, I had to add a new RESUMED state, that represent the moment in which the consumer send the TransferStartMessage to the provider and it's waiting for the TransferStartMessage back from the provider (necessary because in the case of "pull" transfer it will contain the EDR")
The specification does not list a "resume" message so this was the chosen way to do that.

Why it does that

Briefly state why the change was necessary.

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes #3350

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added enhancement New feature or request dataspace-protocol related to the dataspace protocol labels Mar 21, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 87.80488% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 74.08%. Comparing base (7f20ba5) to head (362a353).
Report is 159 commits behind head on main.

Files Patch % Lines
.../connector/transfer/spi/types/TransferProcess.java 60.00% 2 Missing ⚠️
...nsfer/spi/types/command/ResumeTransferCommand.java 0.00% 2 Missing ⚠️
...ctor/transfer/TransferProcessCommandExtension.java 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4027      +/-   ##
==========================================
+ Coverage   71.74%   74.08%   +2.33%     
==========================================
  Files         919      990      +71     
  Lines       18457    20085    +1628     
  Branches     1037     1127      +90     
==========================================
+ Hits        13242    14880    +1638     
+ Misses       4756     4724      -32     
- Partials      459      481      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndr-brt ndr-brt force-pushed the 3350-transfer-resumption branch 3 times, most recently from 6aa10e3 to 362a353 Compare March 21, 2024 12:32
Copy link
Member

@paullatzelsperger paullatzelsperger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe consider RESUMING instead of RESUMED, LGTM otherwise!

@ndr-brt ndr-brt merged commit ab5e7f5 into eclipse-edc:main Mar 27, 2024
16 checks passed
@ndr-brt ndr-brt deleted the 3350-transfer-resumption branch March 27, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dataspace-protocol related to the dataspace protocol enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dsp: handle TransferSuspensionMessage
4 participants