Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix NPE when dataplane is null on data plane signaling client #4039

Merged

Conversation

wolf4ood
Copy link
Contributor

@wolf4ood wolf4ood commented Mar 22, 2024

What this PR changes/adds

fix NPE when dataplane is null on data plane signaling client.

Refactored also the DataPlaneSignalingClientTest with two additional @Nested for Start and Terminate tests

Linked Issue(s)

Closes #4033

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@wolf4ood wolf4ood self-assigned this Mar 22, 2024
@wolf4ood wolf4ood added the bug Something isn't working label Mar 22, 2024
@wolf4ood wolf4ood requested a review from ndr-brt March 22, 2024 15:29
@wolf4ood wolf4ood merged commit fd81ffc into eclipse-edc:main Mar 25, 2024
18 checks passed
@wolf4ood wolf4ood deleted the fix/4033_npe_signaling_flow_controller branch March 25, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataPlaneSignalingFlowController causes NPE if no data-plane is found
2 participants