Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: split Junit module between base utils and the integration test runtime #4042

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

jimmarino
Copy link
Contributor

What this PR changes/adds

Splits the Junit module between base utils and the integration test runtime to avoid circular dependencies between SPI and implementation modules.

Linked Issue(s)

Related to #4028

@jimmarino jimmarino added the refactoring Cleaning up code and dependencies label Mar 23, 2024
@jimmarino jimmarino requested a review from wolf4ood March 23, 2024 18:05
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.19%. Comparing base (7f20ba5) to head (274b2fe).
Report is 163 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4042      +/-   ##
==========================================
+ Coverage   71.74%   74.19%   +2.45%     
==========================================
  Files         919      986      +67     
  Lines       18457    19993    +1536     
  Branches     1037     1117      +80     
==========================================
+ Hits        13242    14834    +1592     
+ Misses       4756     4680      -76     
- Partials      459      479      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jimmarino jimmarino merged commit 73317e3 into eclipse-edc:main Mar 25, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Cleaning up code and dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants