Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support String-Array query parameter in DP public API #4051

Conversation

paullatzelsperger
Copy link
Member

What this PR changes/adds

This PR adds support for multiple identical HTTP query parameters. For example, parameters like foo=bar&foo=baz were collapsed, and only foo=bar was forwarded to the HTTP target.
With this PR, the same query param string is preserved as string-array.

Why it does that

A Tractus-X system standard requires the support of string-array query parameters.

Further notes

  • the DataPlanePublicApiEndToEndTest was improved to verify HTTP requests using the Netty MockServer (instead of calling a dummy URL)
  • The DataPlanePublicApiV2 now supports HEAD requests, they were missing before.
  • By default, requests that hit the public API of the dataplane are classified as PULL flows

NB: that this behaviour will NOT be backported to the legacy version of the public dataplane API!

Linked Issue(s)

Closes #4022

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@paullatzelsperger paullatzelsperger added this to the Milestone 14 milestone Mar 27, 2024
@paullatzelsperger paullatzelsperger added the enhancement New feature or request label Mar 27, 2024
@paullatzelsperger paullatzelsperger added api Feature related to the (REST) api dpf Feature related to the Data Plane Framework labels Mar 27, 2024
@paullatzelsperger paullatzelsperger self-assigned this Mar 27, 2024
@paullatzelsperger paullatzelsperger merged commit 2a2772b into eclipse-edc:main Mar 27, 2024
16 checks passed
@paullatzelsperger paullatzelsperger deleted the feat/4022_support_stringarray_query_param branch March 27, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Feature related to the (REST) api dpf Feature related to the Data Plane Framework enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Http data plane only allows query parameters with unique keys
5 participants