fix: convert RSA private key to JWK #4055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
requested review from
ndr-brt,
bscholtes1A and
jimmarino
as code owners
paullatzelsperger
force-pushed
the
fix/convert_rsa-private-key_to_jwk
branch
from
91f056f
to
21c46c5
Compare
wolf4ood
approved these changes
Mar 27, 2024
paullatzelsperger
force-pushed
the
fix/convert_rsa-private-key_to_jwk
branch
from
21c46c5
to
0ba817e
Compare
ndr-brt
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR allows to convert a RSA key -> JWK if only the private portion of the key is specified by restoring the
public key from the modulus and the exponent.
Why it does that
Using RSA keys in LDP-VPs is impossible otherwise
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes #4054
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.