Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: issue SEVERE message when no DID value provided #4063

Conversation

paullatzelsperger
Copy link
Member

What this PR changes/adds

Only a SEVERE warning message is logged when no edc.iam.issuer.id is provided.

Why it does that

Sometimes it is necessary to have a booted runtime, even if it won't be fully operational.

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes # <-- insert Issue number if one exists

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@paullatzelsperger paullatzelsperger added the enhancement New feature or request label Mar 29, 2024
@paullatzelsperger paullatzelsperger force-pushed the chore/only_issue_error_when_no_issuer-id_config branch from ea44747 to 27b37ec Compare March 29, 2024 07:57
@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 74.02%. Comparing base (7f20ba5) to head (5bf666d).
Report is 179 commits behind head on main.

Files Patch % Lines
.../identitytrust/core/IdentityAndTrustExtension.java 50.00% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4063      +/-   ##
==========================================
+ Coverage   71.74%   74.02%   +2.27%     
==========================================
  Files         919      989      +70     
  Lines       18457    20109    +1652     
  Branches     1037     1126      +89     
==========================================
+ Hits        13242    14885    +1643     
+ Misses       4756     4742      -14     
- Partials      459      482      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paullatzelsperger paullatzelsperger merged commit 6590789 into eclipse-edc:main Mar 29, 2024
16 checks passed
@paullatzelsperger paullatzelsperger deleted the chore/only_issue_error_when_no_issuer-id_config branch March 29, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants