Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: decouple jersey and jetty #4068

Merged
merged 4 commits into from Apr 1, 2024

Conversation

iwasakims
Copy link
Contributor

What this PR changes/adds

It should be decoupling jersey-core and jetty-core

Why it does that

for ease of using user defined web server extension without (or with) using jetty.

Linked Issue(s)

Closes #4067

Signed-off-by: Masatake Iwasaki <iwasakims@gmail.com>
@iwasakims iwasakims added the refactoring Cleaning up code and dependencies label Mar 31, 2024
@iwasakims iwasakims self-assigned this Mar 31, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.54%. Comparing base (7f20ba5) to head (231b9f9).
Report is 186 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4068      +/-   ##
==========================================
+ Coverage   71.74%   74.54%   +2.80%     
==========================================
  Files         919      976      +57     
  Lines       18457    19988    +1531     
  Branches     1037     1122      +85     
==========================================
+ Hits        13242    14901    +1659     
+ Misses       4756     4602     -154     
- Partials      459      485      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jimmarino
Copy link
Contributor

@iwasakims Please update the DEPENDENCIES file by copying the output in the Dash check.

gradle/libs.versions.toml Outdated Show resolved Hide resolved
@jimmarino jimmarino self-requested a review April 1, 2024 07:52
@jimmarino jimmarino merged commit 44f5eef into eclipse-edc:main Apr 1, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Cleaning up code and dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jersey-core and jetty-core should be decoupled
3 participants