Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid NPE when attributes are null #4079

Merged
merged 1 commit into from Apr 3, 2024

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Apr 3, 2024

What this PR changes/adds

Avoid NPEs when TP attributes are null.
The egress transformers should fail as less as possible.

Why it does that

Avoid NPE

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes #4078

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added bug Something isn't working api Feature related to the (REST) api labels Apr 3, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.57%. Comparing base (7f20ba5) to head (df4cabc).
Report is 192 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4079      +/-   ##
==========================================
+ Coverage   71.74%   74.57%   +2.82%     
==========================================
  Files         919      975      +56     
  Lines       18457    19967    +1510     
  Branches     1037     1120      +83     
==========================================
+ Hits        13242    14890    +1648     
+ Misses       4756     4594     -162     
- Partials      459      483      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndr-brt ndr-brt merged commit 41c69db into eclipse-edc:main Apr 3, 2024
16 checks passed
@ndr-brt ndr-brt deleted the 4078-avoid-npe branch April 3, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Feature related to the (REST) api bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPE when querying TransferProcess that are still not requested.
4 participants