Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: several smaller fixes re Credential Revocation #4097

Conversation

paullatzelsperger
Copy link
Member

What this PR changes/adds

This PR fixes some smaller issues with credential revocation, such as caching the StatusList context, using property prefixes, etc.

Why it does that

Needed to utilize the StatusList2021 credential revocation list.

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes # <-- insert Issue number if one exists

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 64.28571% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 74.68%. Comparing base (7f20ba5) to head (56bc9b6).
Report is 202 commits behind head on main.

Files Patch % Lines
.../identitytrust/core/IdentityAndTrustExtension.java 20.00% 4 Missing ⚠️
...t/service/validation/rules/IsInValidityPeriod.java 71.42% 1 Missing and 1 partial ⚠️
...spi/model/statuslist/StatusList2021Credential.java 50.00% 0 Missing and 2 partials ⚠️
...entials/spi/model/statuslist/StatusListStatus.java 81.81% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4097      +/-   ##
==========================================
+ Coverage   71.74%   74.68%   +2.93%     
==========================================
  Files         919      979      +60     
  Lines       18457    20086    +1629     
  Branches     1037     1131      +94     
==========================================
+ Hits        13242    15001    +1759     
+ Misses       4756     4591     -165     
- Partials      459      494      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paullatzelsperger paullatzelsperger added bug Something isn't working iatp labels Apr 8, 2024
@paullatzelsperger paullatzelsperger marked this pull request as ready for review April 8, 2024 12:05
@paullatzelsperger paullatzelsperger force-pushed the fix/several_fixes_for_revocation branch 3 times, most recently from 9b6a960 to 04fa8e2 Compare April 8, 2024 12:46
@paullatzelsperger paullatzelsperger merged commit 07365dc into eclipse-edc:main Apr 8, 2024
16 checks passed
@paullatzelsperger paullatzelsperger deleted the fix/several_fixes_for_revocation branch April 8, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working iatp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants