Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow OBJECT or ARRAY when deserializing VC #4099

Conversation

paullatzelsperger
Copy link
Member

What this PR changes/adds

sometimes VCs are deserialized as plain JSON, e.g. when obtaining StatusList2021 credentials. The spec says that credentialStatus and credentialSubject
can be either an ARRAY or an OBJECT, so a custom deserialization feature is enabled to allow that.

Why it does that

The StatusList2021 specification (and the VC DataModel, for that matter) demand that.

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes # <-- insert Issue number if one exists

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.68%. Comparing base (7f20ba5) to head (998a9a7).
Report is 203 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4099      +/-   ##
==========================================
+ Coverage   71.74%   74.68%   +2.94%     
==========================================
  Files         919      979      +60     
  Lines       18457    20088    +1631     
  Branches     1037     1131      +94     
==========================================
+ Hits        13242    15003    +1761     
+ Misses       4756     4591     -165     
- Partials      459      494      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paullatzelsperger paullatzelsperger merged commit d13ea67 into eclipse-edc:main Apr 9, 2024
18 checks passed
@paullatzelsperger paullatzelsperger deleted the chore/allow_object_or_array branch April 9, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request iatp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants